100% test cover for sqlite driver

pwman/data/drivers/sqlite.py

@@ -29,6 +29,7 @@ import sqlite3 as sqlite
 import pwman.util.config as config
 import itertools
 
+
 def check_db_version():
     """
     check the data base version query the right table
@@ -208,7 +209,8 @@ class SQLiteDatabaseNewForm(Database):
                         " TAGS.ID WHERE TAGS.DATA LIKE ? ")
                 # this is correct if tags are ciphertext
                 p = t._name.strip()
-                # this is wrong, it will work when tags are stored as plain text
+                # this is wrong, it will work when tags are stored as plain
+                # text
                 # p = t.name.strip()
                 p = '%'+p+'%'
                 params = [p]
@@ -266,8 +268,9 @@ class SQLiteDatabaseNewForm(Database):
                     self._cur.execute(sql, [tag])
                 else:
                     self._cur.execute(sql, [tag._name+'%'])
+
                 values = self._cur.fetchall()
-                if values:
+                if values:  # tags already exist in the database
                     ids.extend(list(itertools.chain(*values)))
                 else:
                     self._create_tag(tag)

pwman/tests/db_tests.py

@@ -20,7 +20,7 @@
 from pwman.data.nodes import NewNode
 from pwman.data.tags import TagNew
 from pwman.data import factory
-from pwman.data.drivers.sqlite import DatabaseException
+from pwman.data.drivers.sqlite import DatabaseException, SQLiteDatabaseNewForm
 from pwman.util import config
 from pwman.util.generator import leetlist
 from pwman.util.crypto import CryptoEngine, CryptoBadKeyException
@@ -167,6 +167,9 @@ class DBTests(unittest.TestCase):
         self.db.open()
         self.db.addnodes([node])
 
+    def test_sqlite_init(self):
+        db = SQLiteDatabaseNewForm("test")
+        self.assertEquals("test", db._filename)
 
 class TestDBFalseConfig(unittest.TestCase):
 
@@ -271,6 +274,19 @@ class CLITests(unittest.TestCase):
         # This will pass only when running all the tests then ...
         self.assertEqual(len(rows), 2)
 
+        node = NewNode()
+        node.username = 'alice'
+        node.password = 'dough!'
+        node.url = 'example.com'
+        node.notes = 'somenotes'
+        node.tags = 'lorem ipsum'
+
+        tags = self.tester.cli.get_tags(reader=lambda: u'looking glass')
+        node.tags = tags
+        self.tester.cli._db.addnodes([node])
+
+
+
     def test_get_ids(self):
         # used by do_cp or do_open,
         # this spits many time could not understand your input

pwman/util/callback.py

@@ -52,7 +52,7 @@ class Callback(object):  # pragma: no cover
         pass
 
 
-class CLICallback(Callback):
+class CLICallback(Callback):  # pragma: no cover
     def getinput(self, question):
         return raw_input(question)